Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.2 compatibility, bump min. version to 8.1 #1042

Merged
merged 3 commits into from
Dec 13, 2022
Merged

PHP 8.2 compatibility, bump min. version to 8.1 #1042

merged 3 commits into from
Dec 13, 2022

Conversation

MyIgel
Copy link
Member

@MyIgel MyIgel commented Dec 11, 2022 •
edited

Make the Engelsystem PHP 8.2 compatible and updates packages

Closes #1022

@MyIgel MyIgel added Type: Task A todo point, mostly no coding task. Status: In Progress Fixing this issue is in progress. Dependencies Pull requests that update a dependency file labels Dec 11, 2022
@MyIgel MyIgel added this to the Complete first rewrite milestone Dec 11, 2022
@MyIgel MyIgel added this to Backlog in Engelsystem via automation Dec 11, 2022
@MyIgel MyIgel marked this pull request as draft December 11, 2022 23:41
@MyIgel
Copy link
Member Author

MyIgel commented Dec 11, 2022

At the moment it requires FakerPHP/Faker#570 to be merged and a new package version released for the CI to run without warnings which get converted to errors.

@ximex
Copy link
Contributor

ximex commented Dec 12, 2022

why not allow 8.0? It's still supported
also update node?
FROM node:14-alpine as themes -> FROM node:18-alpine as themes

@MyIgel
Copy link
Member Author

MyIgel commented Dec 13, 2022 •
edited

Updating node is way out of scope here..
(also the current version is still supported so why even trying to get through the pain of updating a build only dependency...)
We could move the 8.1 update to a later date but it would be useful to already have support for some 8.1 features like new in initializers and intersection types but that can be discussed i guess. There might also be some package dependencies which i had to check then again.

@MyIgel
Copy link
Member Author

MyIgel commented Dec 13, 2022

(and also the current stable / lts versions of debian and ubuntu package 8.1 so thats no problem either)

@MyIgel
Copy link
Member Author

MyIgel commented Dec 13, 2022

Faker got updated so this can be tested and merged 🎉

@MyIgel MyIgel marked this pull request as ready for review December 13, 2022 14:58
@weeman1337 weeman1337 merged commit 99e7a08 into engelsystem:main Dec 13, 2022
Engelsystem automation moved this from Backlog to Done Dec 13, 2022
@MyIgel MyIgel deleted the php-updates branch December 13, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

Assignees
No one assigned
Labels
Dependencies Pull requests that update a dependency file Status: In Progress Fixing this issue is in progress. Type: Task A todo point, mostly no coding task.
Projects
Engelsystem
  
Done
Milestone
Complete first rewrite
Development

Successfully merging this pull request may close these issues.

Drop PHP 7.4 Support
3 participants
@MyIgel @ximex @weeman1337