Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better typescript setup for monorepo #17

Merged
merged 15 commits into from Sep 3, 2019
Merged

Better typescript setup for monorepo #17

merged 15 commits into from Sep 3, 2019

Conversation

kosecki123
Copy link
Contributor

@kosecki123 kosecki123 commented Sep 3, 2019 •
edited

  • Project paths - allows go to the definition in VSCode without previous build
  • Project references - allows to build single projects
  • Use incremental builds - faster builds

Setup inspired by https://medium.com/@NiGhTTraX/how-to-set-up-a-typescript-monorepo-with-lerna-c6acda7d4559

@e00dan
Copy link
Contributor

e00dan commented Sep 3, 2019

For Origin UI incremental builds we're probably blocked by:

For ts-node incremental builds we're probably blocked by:

@e00dan e00dan requested review from e00dan and josipbagaric and removed request for e00dan September 3, 2019 14:58
@e00dan e00dan marked this pull request as ready for review September 3, 2019 14:58
kosecki123
kosecki123 commented Sep 3, 2019
View reviewed changes
packages/user-registry/src/test/UserLogicFacade.ts Outdated
@@ -131,7 +131,7 @@ describe('UserLogic Facade', () => {
const emptyAccount = await new User(user2, conf).sync();
delete emptyAccount.configuration;

assert.deepEqual(emptyAccount, {
assert.deepEqual<Partial<User>>(emptyAccount, {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kosecki123
Copy link
Contributor Author

Nice work @kuzirashi 💯 Ready to merge.

@kosecki123 kosecki123 merged commit 9e4b725 into master Sep 3, 2019
@kosecki123 kosecki123 deleted the monorepo-ts-setup branch September 3, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e00dan e00dan e00dan approved these changes

@josipbagaric josipbagaric josipbagaric approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kosecki123 @e00dan @josipbagaric