Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(daemon,cli): Make and store at path #2281

Merged
merged 3 commits into from May 15, 2024
Merged

feat(daemon,cli): Make and store at path #2281

merged 3 commits into from May 15, 2024

Conversation

kriskowal
Copy link
Member

@kriskowal kriskowal commented May 9, 2024 •
edited by rekmarks

Enables caplets to be made and values to be stored at deeper pet name paths.

endo make x.js -n dir.x
endo store --json 42 -n dir.forty-two
endo store --text-stdin --name dir.greeting < <(echo hi)

@kriskowal kriskowal requested a review from rekmarks May 9, 2024 19:55
@rekmarks rekmarks mentioned this pull request May 14, 2024
Open
24 tasks
@rekmarks rekmarks force-pushed the kriskowal-daemon-caplet-and-store-path branch from e15f917 to d54402d Compare May 15, 2024 17:20
@rekmarks rekmarks marked this pull request as ready for review May 15, 2024 18:09
rekmarks
rekmarks approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-dealing approval.

kriskowal
kriskowal commented May 15, 2024
View reviewed changes
packages/cli/src/endo.js
@@ -370,7 +371,7 @@ export const main = async rawArgs => {
storeJson,
storeJsonStdin,
storeBigInt,
name,
name: parsePetNamePath(name),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really ought to be done in store.js to keep endo.js light and loosely coupled.

@kriskowal kriskowal merged commit 85767ae into master May 15, 2024
17 checks passed
@kriskowal kriskowal deleted the kriskowal-daemon-caplet-and-store-path branch May 15, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rekmarks rekmarks rekmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kriskowal @rekmarks