refactor(daemon): Prefer storeValue() where possible in tests
#2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekmarks
force-pushed
the
rekmarks-use-storeValue-in-tests
branch
3 times, most recently
from
1ca21f6
to
db1dc97
Compare
rekmarks
changed the title
storeValue() where possible in testsstoreValue() where possible in tests
kriskowal
approved these changes
May 9, 2024
Prefer `storeValue()` over more complicated `evaluate()` incantations in tests when we just need some named value to exist.
rekmarks
force-pushed
the
rekmarks-use-storeValue-in-tests
branch
from
db1dc97
to
5d41e8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer
storeValue()over more complicatedevaluate()incantations in tests when we just need some named value to exist.