Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump TypeScript to 5.5 beta #2257

Merged
merged 4 commits into from May 13, 2024
Merged

bump TypeScript to 5.5 beta #2257

merged 4 commits into from May 13, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Apr 29, 2024

no issue

Description

https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-beta/

That required cleaning up @types/node that was stuck on v16.

I tried bumping typescript-eslint but that introduced some perf warnings about our tsconfig.

Security Considerations

n/a, types

Scaling Considerations

n/a, types

Documentation Considerations

no

Testing Considerations

CI

Compatibility Considerations

n/a, types

Upgrade Considerations

none

@turadg turadg requested a review from kriskowal April 29, 2024 20:50
@turadg turadg marked this pull request as draft April 30, 2024 00:04
@turadg
Copy link
Member Author

turadg commented Apr 30, 2024

It's not clear what's causing the build failure . May be a bug in TS 5.5 beta.

@turadg
Copy link
Member Author

turadg commented Apr 30, 2024

It's not clear what's causing the build failure . May be a bug in TS 5.5 beta.

It's a change in the beta but apparently intentional: #2260

@turadg turadg force-pushed the ta/typescript-5.5-beta branch 3 times, most recently from 746dde3 to 967f098 Compare May 13, 2024 21:31
was erroring:
TS1337: An index signature parameter type cannot be a literal type or generic type. Consider using a mapped object type instead.

This adopts the type from Object.fromEntries
@turadg turadg marked this pull request as ready for review May 13, 2024 21:46
@@ -140,6 +140,10 @@ export const makeCapTP = (
const seen = new Set();

return harden({
/**
* @param {T} specimen
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Is the specimen ready?

@turadg turadg merged commit fa20921 into master May 13, 2024
17 checks passed
@turadg turadg deleted the ta/typescript-5.5-beta branch May 13, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants