feat(ses): fix conflicting definitions of %InertAsyncFunction% on Hermes #2221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
leotm
force-pushed
the
ses-hermes-getAnonymousIntrinsics-p2
branch
from
cb1073a
to
4fac67d
Compare
|
Because of other use cases (like extensions) we can't rely on eval to get the intrinsics. There is an open issue about verifying that the ses shim wasn't transpiled, which seems to be what's happening here. See #902 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #XXXX
refs: #1891
Description
Context: Running SES on React Native on Android (Hermes)
Follow-up to
When calling
addIntrinsics(getAnonymousIntrinsics())The way we define AsyncFunctionInstance
async function AsyncFunctionInstance() {}is throwing
TypeError: Conflicting definitions of %InertAsyncFunction%at https://github.com/endojs/endo/blob/master/packages/ses/src/intrinsics.js#L46
which doesn't match what's returned from
(0,eval)('(async function () { })');which is ok in reproleotm/RN07117SES@cb44efd
Security Considerations
Likely since calling eval
Scaling Considerations
Documentation Considerations
Testing Considerations
Compatibility Considerations
Upgrade Considerations
*BREAKING*:in the commit message with migration instructions for any breaking change.NEWS.mdfor user-facing changes.