Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scripts): Add esbench microbenchmarking utility #2204

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 commented Apr 6, 2024

Measure performance of code snippets in multiple ECMAScript implementations using the eshost CLI.

TODO:

  • Improve output to include aggregate statistics like standard deviation, min/median/max, etc.
  • Support collecting performance data for flame graphs etc. (probably bypassing eshost).
  • Support loading endoZipBase64 bundles?

@gibson042 gibson042 requested a review from erights April 6, 2024 04:11
@erights
Copy link
Contributor

erights commented Apr 9, 2024

PR comment should first of all say with the PR does contribute. TODOs are nice but secondary.

Need explanations with examples.

I don't know how amenable this is to testing, but presumably we could at least have some smoke tests so we find out if we break it egregiously.

Smoke tests can often serve as expository examples, if that works out. I don't know if it would here.

@gibson042 gibson042 force-pushed the gibson-2197-esbench branch 3 times, most recently from 36c9024 to 1464af8 Compare May 2, 2024 14:40
Copy link
Contributor

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just recording here what @gibson042 and I discussed awhile ago:

Rather than this heavy command-line orientation and separate process oriented implementation, we will shift to something that more closely resembles a simplified ses-ava-like framework, where writing bench cases feels much more like writing ses-ava test cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants