feat(compartment-mapper): expose loadCompartmentForArchive #2189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @boneskull and the rest of your teammates on |
boneskull
force-pushed
the
boneskull/load-compartment-for-archive
branch
from
5fe0f92
to
8f632a2
Compare
boneskull
force-pushed
the
boneskull/load-compartment-for-archive
branch
from
8f632a2
to
7dfbd98
Compare
This extracts a function, `loadCompartmentForArchive()`, from `digestLocation()` in `archive.js`, and exposes it. This function returns archival-ready data structures, in addition to a record of the compartment renames which `makeArchiveCompartmentMap()` performs. The intent is to leverage the module resolution performed by the function, which is reflected in its output. A consumer can use the information therein to perform additional operations on the tree (e.g., parse ASTs). # Conflicts: # packages/compartment-mapper/src/types.js
boneskull
force-pushed
the
boneskull/load-compartment-for-archive
branch
from
7dfbd98
to
7834bec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This extracts a function,
loadCompartmentForArchive(), fromdigestLocation()inarchive.js, and exposes it. This function returns archival-ready data structures, in addition to a record of the compartment renames whichmakeArchiveCompartmentMap()performs.The intent is to leverage the module resolution performed by the function, which is reflected in its output. A consumer can use the information therein to perform additional operations on the tree (e.g., parse ASTs).
Upgrade Considerations
This is a backwards-compatible change