test(marshal,ses): Prefer test.skip over conditional early return #2099
+48
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
LGTM, thanks.
That's a nice way of abstracting things. Would be worth keeping if the underlying problem were long term. But AggregateError has been standard for awhile. Please at least insert TODOs to remove all this extra indirection and simplify, once we no longer need to support pre-AggregateError platforms.
gibson042
force-pushed
the
gibson-2042-followup
branch
from
9e354f8
to
a98519a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #2042
Ref #550
Description
Some missed improvements related to #2042 (review) .