feat(cli,daemon): Support pet name paths in kill command
#2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
kumavis
reviewed
Feb 9, 2024
kumavis
reviewed
Feb 9, 2024
Adds support for dot-delimited pet name paths to the `kill` command. Makes requisite changes to handle paths and lookup formulas in the mailbox `terminate()` method.
rekmarks
force-pushed
the
rekmarks-kill-with-dot-path
branch
3 times, most recently
from
ab7145d
to
dbe0250
Compare
When lookup formulas were introduced, they inadvertently made broke reverse lookup of their values by overwriting the original formula identifiers in the ref -> formula id memoization table (`formulaIdentifierForRef`). This made it impossible to terminate a value mediated by a lookup formula. This is fixed by introducing a circular dependency between lookup formulas and their values, such that if either is terminated, both are terminated.
rekmarks
force-pushed
the
rekmarks-kill-with-dot-path
branch
from
dbe0250
to
0a8210f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2023
Adds support for dot-delimited pet name paths to the
killcommand. Makes requisite changes to handle paths and lookup formulas in the mailboxterminate()method.