Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Babel 7.23 #1893

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Upgrade Babel 7.23 #1893

merged 5 commits into from
Dec 12, 2023

Conversation

kriskowal
Copy link
Member

@kriskowal kriskowal commented Dec 11, 2023

closes: #1846

Description

This should put #1846 to bed. The latest patch releases for Babel have addressed the property override mistake observed while bundling under lockdown.

As evidence, integrating this branch into Agoric SDK Agoric/agoric-sdk#8514 obviates the need to run the bundler with overrideTaming: severe.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@mhofman
Copy link
Contributor

mhofman commented Dec 12, 2023

Nit title: 7.23 not 2.23

@kriskowal kriskowal marked this pull request as ready for review December 12, 2023 00:06
@kriskowal kriskowal changed the title Upgrade Babel 2.23 Upgrade Babel 7.23 Dec 12, 2023
@kriskowal
Copy link
Member Author

Nit title: 7.23 not 2.23

Fixed

image

Copy link
Contributor

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run a npx yarn-deduplicate

@@ -37,14 +37,12 @@
".": {
"types": "./types.d.ts",
"import": "./index.js",
"require": "./dist/ses.cjs",
"types": "./types.d.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "types" changes seem unrelated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. This was a byproduct of running ./scripts/set-versions.sh, which went ahead and removed the duplicate key from this package.json.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and I’m retaining an individual commit for this change so it’s easy to identify/remove/move. I’ll accommodate your preference. Mine is to preserve the commit and save time.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I missed the duplication!

@kriskowal
Copy link
Member Author

Please run a npx yarn-deduplicate

Done.

Copy link
Contributor

@mhofman mhofman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After dedup, the diff of the yarn.lock looks as expected. If tests pass, we should be good to go.

PS: to double check, you ran yarn install after npx yarn-deduplicate to make sure the yarn.lock was stable?

@@ -37,14 +37,12 @@
".": {
"types": "./types.d.ts",
"import": "./index.js",
"require": "./dist/ses.cjs",
"types": "./types.d.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I missed the duplication!

@kriskowal
Copy link
Member Author

After dedup, the diff of the yarn.lock looks as expected. If tests pass, we should be good to go.

PS: to double check, you ran yarn install after npx yarn-deduplicate to make sure the yarn.lock was stable?

I did not and it was not stable. Please see the new commit.

@kriskowal kriskowal merged commit 4557bb8 into master Dec 12, 2023
14 checks passed
@kriskowal kriskowal deleted the kriskowal-babel-7.23 branch December 12, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Babel versions circa 7.20 are incompatible with Hardened JavaScript
2 participants