fix: tolerate empty func.prototype #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Works
approved these changes
Jun 18, 2022
kriskowal
reviewed
Jun 18, 2022
Comment on lines
+290
to
+292
| if (obj.prototype === undefined) { | ||
| // eslint-disable-next-line @endo/no-polymorphic-call | ||
| console.warn(`Tolerating undeletable ${subPath} === undefined`); |
There was a problem hiding this comment.
Hmm. Unless the prototype: 'undefined' property is explicitly defined in the whitelist?
There was a problem hiding this comment.
In any case, for present purposes, I prefer that it always warn.
kriskowal
approved these changes
Jun 18, 2022
zloirock
reviewed
Jun 21, 2022
|
|
||
| test('tolerate empty prototype', t => { | ||
| t.assert('prototype' in Array.prototype.push); | ||
| t.is(Array.prototype.push.prototype, undefined); |
There was a problem hiding this comment.
Array.prototype.push.prototype here is not set to undefined, so it's an object, no?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See zloirock/core-js#1092
If a primordial method is whitelisted as
fn, then it is not supposed to haveprototypeproperty. However, as explained by zloirock/core-js#1092 , there is some desire to runcore-jsas a vetted shim, i.e., a shim run beforelockdownthat does not break any of the invariants that SES depends on. However, the core-js shim also targets ES5, and there's no good option in ES5 for making a replacement primordial function that does not have an undeletableprototypeproperty.With this PR, our whitelisting, on encountering such a function, instead sets its
prototypetoundefinedand then checks that it has done so. If so, then it issues a warning but allows the whitelisting to continue.