Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github actions versions #279

Merged
merged 10 commits into from Mar 29, 2022
Merged

Conversation

nappex
Copy link
Collaborator

@nappex nappex commented Mar 18, 2022

No description provided.

@nappex
Copy link
Collaborator Author

nappex commented Mar 18, 2022

jiri-one
jiri-one previously approved these changes Mar 25, 2022
@jiri-one jiri-one self-requested a review March 25, 2022 07:25
@nappex
Copy link
Collaborator Author

nappex commented Mar 25, 2022

It seems as problem with configuration cache: 'pip'

Error message:
No file in /home/runner/work/freezeyt/freezeyt matched to [**/requirements.txt], make sure you have checked out the target repository

It is looking for requirements.txt but we use setup.cfg

docs says:
By default, the action searches for the dependency file (requirements.txt for pip or Pipfile.lock for pipenv) in the whole repository. Use the cache-dependency-path input for cases when you want to override current behaviour and use different file for hash generation (for example requirements-dev.txt). This input supports wildcards or a list of file names for caching multiple dependencies.

Issue: actions/setup-python#328

@nappex
Copy link
Collaborator Author

nappex commented Mar 25, 2022

Again action did not start :(

@jiri-one jiri-one dismissed their stale review March 25, 2022 10:01

because it is not working.

@encukou
Copy link
Owner

encukou commented Mar 25, 2022

It is looking for requirements.txt but we use setup.cfg

Oh. Never mind, I guess we can't use pip cache yet.

@encukou
Copy link
Owner

encukou commented Mar 25, 2022

GitHub had some outages recently: https://www.githubstatus.com/#past-incidents
Pushing a new commit should start the actions. So should closing & reopening the PR, if I recall correctly.

@nappex nappex closed this Mar 25, 2022
@nappex nappex reopened this Mar 25, 2022
@nappex
Copy link
Collaborator Author

nappex commented Mar 25, 2022

Oh. Never mind, I guess we can't use pip cache yet.

We can the cache-dependency-path helped. uuuaaa 🚀 🎆

with:
python-version: '3.8'
cache: 'pip'
cache-dependency-path: '**/setup.cfg'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup-python's default behavior is to look for requirements.txt in all subdirectories, but here we don't need the **/.
We also might want to switch to pyproject.toml entirely in the future, when setuptools supports it, so consider:

Suggested change
cache-dependency-path: '**/setup.cfg'
cache-dependency-path: |
setup.cfg
pyproject.toml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we can discuss it on stream because I am not sure about that

@encukou encukou merged commit a56b7c4 into encukou:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants