Suppress side-effects of signal propagation #2317
Open
+19
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR suppresses noise and dirt from signal propagation introduced in #1600.
multiprocessing.process
on any exception. Since the shutdown exception is expected, subprocesses spawned for workers/reload simply discard it.uvicorn.run
exits. This would previously be skipped on forced shutdown.Note: I was not able to reproduce #2281 / #2289 so I do not know if they are fixed by this. However, this fixes the various reports on those discussions/issues about tracebacks.
I do not have access to a Windows machine for testing so had to emulate it. It would be nice if someone can confirm that this works on Windows.A minimal repro is the programrun via
@johanboekhoven kindly tested this on Windows.
Checklist