Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dualstack IPv6/IPv4 support #2266

Closed
wants to merge 1 commit into from
Closed

Conversation

Strangerxxx
Copy link

@Strangerxxx Strangerxxx commented Mar 6, 2024

Summary

This PR meant to fix over two years discussion about supporting dual stack (ipv6/ipv4) for uvicorn:
#1529

However, since I'm not a Python developer this changes are need in a bit effort from Uvicorn team (at least to align test).

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@Kludex
Copy link
Sponsor Member

Kludex commented Mar 19, 2024

Is this meant to implement what I said here: #1529 (reply in thread) ?

@Kludex
Copy link
Sponsor Member

Kludex commented Apr 13, 2024

I'm closing this as stale.

This PR fails on --reload.

If someone wants this to happen, please read the whole discussion #1529 (reply in thread), and feel free to open a PR with the proposal.

@Kludex Kludex closed this Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants