Suggesting using existing process manager in docs #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
commented
Dec 5, 2023
docs/deployment.md
Outdated
Comment on lines
185
to
189
| Modern deployments often are deployed on a Softare as a Service platform or a Platform as a Service. | ||
| Examples include various offerings from AWS, GCP, Render, fly.io and Kubernetes (availble as a service on many cloud providers). | ||
| These are just examples, Uvicorn does not necessarily recommend or endorse any of these above other options. | ||
| Kubernetes for example functions both as a process manager and load balancer. | ||
| These options can range form simple to complex, and they may not be better than other options listed below, but if you are already using Kubernetes or another option that offers load balancing and process maangement you do not need to also run your own process manager and load balancer. |
There was a problem hiding this comment.
I'm open to any other wording here.
The point I want to get across is that if you're already deploying on something that does load balancing and process management there is no point in duplicating that into your app.
Kludex
reviewed
Dec 5, 2023
adriangb
commented
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.