Log exception traceback in case of invalid HTTP request when using h11 #1945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author: florimondmanca (https://github.com/florimondmanca)
Source: #889
Revert PR: #1518
Motivation: I absolutely don't understand why this commit was reverted, if there are errors during execution you shouldn't keep quiet about them. Today I encountered the error
Invalid HTTP request received.
and I was stumped for hours because of it. After adding a traceback of the error it immediately became clear:h11._util.RemoteProtocolError: Missing mandatory Host: header
. The funny thing about this error is that it appeared to me only if I used reverse proxy NGINX,