-
-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace current WSGIMiddleware implementation by a2wsgi one #1825
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0e40358
Replace current WSGIMiddleware implementation by a2wsgi one
humrochagf c0b5bdd
Move a2wsgi to base dependencies and update docs accordingly
humrochagf c5b071f
Revert wsgi removal
humrochagf f91bc36
Revert tests and deprecate WSGIMiddleware
humrochagf 1c9a510
Update tests to validate lib and non lib cases
humrochagf 27edadd
Add a2wsgi to testing requirements
humrochagf 124946c
Fix typo in requirements
humrochagf da713f3
Add deprecation warning
humrochagf 19ca8d4
Update docs
humrochagf 594733c
Revert index docs and add note to settings interface
humrochagf 0350c10
Update middleware with code change sugested
humrochagf f471027
Remove import magic in tests
humrochagf d2512bb
Update error message
humrochagf 87406c4
Simplify tests
0db9f30
Better wording in error and type ignores
humrochagf File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,6 +11,7 @@ build==0.9.0 | |
twine==4.0.1 | ||
|
||
# Testing | ||
a2wsgi==1.6.0 | ||
autoflake==1.7.7 | ||
black==22.10.0 | ||
flake8==3.9.2 | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand why you did this, but I don't think it's the right type. It should be
NoReturn
🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the typechecker perspective WSGIMiddleware expects a function that has
List[bytes]
as return type, if it aways fails into exception is not that important.This type error started to be more clear because the a2wsgi WSGIMiddleware is less permissive in terms of functions it accepts.