Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test scenario for --uds flag when file exists #1741

Merged
merged 4 commits into from Oct 29, 2022
Merged

Add test scenario for --uds flag when file exists #1741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
471f99d
wip: add logic ts to improve coverage
iudeen Oct 28, 2022
673ef0a
Create uds_file fixture
Kludex Oct 29, 2022
a3d90a3
Adjust fail_under number
Kludex Oct 29, 2022
c9e4d21
Add pragma on Windows
Kludex Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Expand Up @@ -82,7 +82,7 @@ plugins =

[coverage:report]
precision = 2
fail_under = 97.69
fail_under = 97.79
show_missing = true
skip_covered = true
exclude_lines =
Expand Down
14 changes: 12 additions & 2 deletions tests/test_cli.py
View file
Open in desktop
Expand Up @@ -91,10 +91,20 @@ def test_cli_call_multiprocess_run() -> None:
mock_run.assert_called_once()


@pytest.fixture(params=(True, False))
def uds_file(
tmp_path: Path, request: pytest.FixtureRequest
) -> Path: # pragma: py-win32
file = tmp_path / "uvicorn.sock"
should_create_file = request.param
if should_create_file:
file.touch(exist_ok=True)
return file


@pytest.mark.skipif(sys.platform == "win32", reason="require unix-like system")
def test_cli_uds(tmp_path: Path) -> None: # pragma: py-win32
def test_cli_uds(uds_file: Path) -> None: # pragma: py-win32
runner = CliRunner()
uds_file = tmp_path / "uvicorn.sock"

with mock.patch.object(Config, "bind_socket") as mock_bind_socket:
with mock.patch.object(Multiprocess, "run") as mock_run:
Expand Down