Add no-server-header support for Web Socket implementations #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adopted change suggested. Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
as per suggestion, moved the limitation to --no-server-header area
Added logic to add server header support for websockets and also to pass default headers
Added logic to add server header support for websockets and also to pass default headers
* added logic to accept default headers in websocket * added default_headers to class init * fix * feat(websockets): added server header support for websockets Added logic to add server header support for websockets and also to pass default headers * feat(websockets-wsproto): added server header support for websockets Added logic to add server header support for websockets and also to pass default headers Co-authored-by: Irfanuddin <irfanuddin@knowledgelens.com>
# Conflicts: # uvicorn/protocols/websockets/websockets_impl.py # uvicorn/protocols/websockets/wsproto_impl.py
…sockets" This reverts commit 62c6c7e
--no-date-header is also not compatible with Websockets
--no-date-header is also not compatible with Websockets
Suggestion removes duplication check on header names to keep it consistent with http implementations. Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com> Co-authored-by: Irfanuddin <irfanuddinshafi@gmail.com>
…-headers # Conflicts: # setup.py
Remove the line about limitation of `no-server-header` from docs.
…-headers # Conflicts: # requirements.txt
…-headers # Conflicts: # uvicorn/protocols/websockets/websockets_impl.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for the purpose of review. I cannot target an outside branch. This is the same as #1606.