Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade request handling: ignore http/2 and optionally ignore websocket #1661

Merged
merged 13 commits into from Oct 19, 2022
Merged

Upgrade request handling: ignore http/2 and optionally ignore websocket #1661

merged 13 commits into from Oct 19, 2022
+125 −57

Commits on Sep 21, 2022

  1. Add option to ignore upgrade requests (encode#1659)

    @Argannor
    Argannor committed Sep 21, 2022
    Copy the full SHA
    cc9894e View commit details
    Browse the repository at this point in the history

  2. Ignore all non-supported upgrade requests (i.e. everything except web… 

    …socket) (encode#1501)
    @Argannor
    Argannor committed Sep 21, 2022
    Copy the full SHA
    64cb993 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Remove redundant upgrade protocol checks and convert --ws-ignore-upgr… 

    …ade to a flag
    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    6d3e802 View commit details
    Browse the repository at this point in the history

  2. Use self.headers instead of passing headers around

    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    23d9644 View commit details
    Browse the repository at this point in the history

  3. Change help of --ws-ignore-upgrade

    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    5e2d940 View commit details
    Browse the repository at this point in the history

  4. Refactor: Rename handle_upgrade to handle_websocket_upgrade

    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    04429b7 View commit details
    Browse the repository at this point in the history

  5. Change help of --ws-ignore-upgrade

    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    5086cd0 View commit details
    Browse the repository at this point in the history

  6. Docs: Update explanation of --ws-ignore-upgrade to match the help text

    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    15516ab View commit details
    Browse the repository at this point in the history

  7. Refactor: remove unused parameter

    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    13d3ea2 View commit details
    Browse the repository at this point in the history

  8. Refactor: remove unused parameter (fixed)

    @Argannor
    Argannor committed Sep 22, 2022
    Copy the full SHA
    ce07b55 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. test: parameterize ws_ignore_upgrade during http2 upgrade test

    @Argannor
    Argannor committed Sep 26, 2022
    Copy the full SHA
    ac4c47d View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. Remove --ws-ignore-upgrade flag and base decision on --ws setting and… 

    … availability of a ws implementation.
    @Argannor
    Argannor committed Sep 28, 2022
    Copy the full SHA
    f7a2c40 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Test: replace custom logger mock with caplog

    @Argannor
    Argannor committed Sep 30, 2022
    Copy the full SHA
    14cca48 View commit details
    Browse the repository at this point in the history