Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default headers to WebSockets implementations #1606

Merged
merged 69 commits into from Oct 28, 2022
Merged

Add default headers to WebSockets implementations #1606

merged 69 commits into from Oct 28, 2022

Commits on Jul 15, 2022

  1. added logic to accept default headers in websocket

    @iudeen
    iudeen committed Jul 15, 2022
    Copy the full SHA
    d8a87a5 View commit details
    Browse the repository at this point in the history

  2. added default_headers to class init

    @iudeen
    iudeen committed Jul 15, 2022
    Copy the full SHA
    170f16a View commit details
    Browse the repository at this point in the history

  3. fix

    Irfanuddin committed Jul 15, 2022
    Copy the full SHA
    bd28f39 View commit details
    Browse the repository at this point in the history

  4. docs: added limitation about Websockets

    Irfanuddin committed Jul 15, 2022
    Copy the full SHA
    83a29e8 View commit details
    Browse the repository at this point in the history

  5. docs: added limitation about Websockets

    Irfanuddin committed Jul 15, 2022
    Copy the full SHA
    eabe380 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Update docs/settings.md 

    adopted change suggested.

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    @iudeen @Kludex
    iudeen and Kludex committed Jul 22, 2022
    Copy the full SHA
    5ecfd07 View commit details
    Browse the repository at this point in the history

  2. docs: moved websocket limitation 

    as per suggestion, moved the limitation to --no-server-header area
    Irfanuddin committed Jul 22, 2022
    Copy the full SHA
    d954ef1 View commit details
    Browse the repository at this point in the history

  3. Update docs/settings.md

    @Kludex
    Kludex committed Jul 22, 2022
    Copy the full SHA
    c7546bd View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2022

  1. Merge remote-tracking branch 'origin/master' into patch/websocket-ser… 

    …ver-name
    Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    eef254d View commit details
    Browse the repository at this point in the history

  2. feat(websockets): added server header support for websockets 

    Added logic to add server header support for websockets and also to pass default headers
    Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    f7fc772 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'encode:master' into master

    @iudeen
    iudeen committed Jul 25, 2022
    Copy the full SHA
    87408cf View commit details
    Browse the repository at this point in the history

  4. feat(websockets-wsproto): added server header support for websockets 

    Added logic to add server header support for websockets and also to pass default headers
    Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    62c6c7e View commit details
    Browse the repository at this point in the history

  5. added logic to accept default headers in websocket (#1) 

    * added logic to accept default headers in websocket

* added default_headers to class init

* fix

* feat(websockets): added server header support for websockets

Added logic to add server header support for websockets and also to pass default headers

* feat(websockets-wsproto): added server header support for websockets

Added logic to add server header support for websockets and also to pass default headers

Co-authored-by: Irfanuddin <irfanuddin@knowledgelens.com>
    @iudeen
    iudeen and Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    4928484 View commit details
    Browse the repository at this point in the history

  6. style(websockets): formatting

    Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    d4c55c7 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'patch/websocket-server-name' 

    # Conflicts:
#	uvicorn/protocols/websockets/websockets_impl.py
#	uvicorn/protocols/websockets/wsproto_impl.py
    Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    8e44b69 View commit details
    Browse the repository at this point in the history

  8. style(websockets): formatting

    Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    4c860f7 View commit details
    Browse the repository at this point in the history

  9. style(websockets): formatting

    Irfanuddin committed Jul 25, 2022
    Copy the full SHA
    728b4b9 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Merge branch 'encode:master' into master

    @iudeen
    iudeen committed Aug 12, 2022
    Copy the full SHA
    2beab89 View commit details
    Browse the repository at this point in the history

  2. revert(websockets): removed work-around logic to add headers

    Irfanuddin committed Aug 12, 2022
    Copy the full SHA
    7a8aa99 View commit details
    Browse the repository at this point in the history

  3. Revert "feat(websockets-wsproto): added server header support for web… 

    …sockets"

This reverts commit 62c6c7e
    Irfanuddin committed Aug 12, 2022
    Copy the full SHA
    94ddfe5 View commit details
    Browse the repository at this point in the history

  4. feat(wsproto): Add headers support for wsproto implementation

    Irfanuddin committed Aug 12, 2022
    Copy the full SHA
    49b135b View commit details
    Browse the repository at this point in the history

  5. docs: added limitation about Websockets - no-date-header 

    --no-date-header is also not compatible with Websockets
    Irfanuddin committed Aug 12, 2022
    Copy the full SHA
    f4ada86 View commit details
    Browse the repository at this point in the history

  6. docs: added limitation about Websockets - no-date-header 

    --no-date-header is also not compatible with Websockets
    Irfanuddin committed Aug 12, 2022
    Copy the full SHA
    7a08ff0 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. Update uvicorn/protocols/websockets/wsproto_impl.py 

    Suggestion removes duplication check on header names to keep it consistent with http implementations.

Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    @iudeen @Kludex
    iudeen and Kludex committed Aug 15, 2022
    Copy the full SHA
    137fd38 View commit details
    Browse the repository at this point in the history

  2. revert: removed default header logic

    Irfanuddin committed Aug 15, 2022
    Copy the full SHA
    e241caa View commit details
    Browse the repository at this point in the history

  3. test: added test for wsproto implementation

    Irfanuddin committed Aug 15, 2022
    Copy the full SHA
    eede8f4 View commit details
    Browse the repository at this point in the history

  4. style: fixed linting

    Irfanuddin committed Aug 15, 2022
    Copy the full SHA
    62cbf96 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. test: added test for multiple server headers

    Irfanuddin committed Aug 16, 2022
    Copy the full SHA
    877a9fc View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2022

  1. Feature/new (#2) 

    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Co-authored-by: Irfanuddin <irfanuddinshafi@gmail.com>
    @iudeen @Kludex
    3 people committed Aug 20, 2022
    Copy the full SHA
    1cbf30c View commit details
    Browse the repository at this point in the history

  2. flake-8 corrections

    @iudeen
    iudeen committed Aug 20, 2022
    Copy the full SHA
    b061ede View commit details
    Browse the repository at this point in the history

  3. run black

    @iudeen
    iudeen committed Aug 20, 2022
    Copy the full SHA
    02c96e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2022

  1. Added support for no-server-header in Websocket Protocols

    @iudeen
    iudeen committed Aug 21, 2022
    Copy the full SHA
    3c6c915 View commit details
    Browse the repository at this point in the history

  2. ran black

    @iudeen
    iudeen committed Aug 21, 2022
    Copy the full SHA
    9b79b31 View commit details
    Browse the repository at this point in the history

  3. update requirements.txt

    @iudeen
    iudeen committed Aug 21, 2022
    Copy the full SHA
    1548e92 View commit details
    Browse the repository at this point in the history

  4. Revert "update requirements.txt" 

    This reverts commit 1548e92.
    @iudeen
    iudeen committed Aug 21, 2022
    Copy the full SHA
    2b7267f View commit details
    Browse the repository at this point in the history

  5. update requirements to use wip main branch from Websockets

    @iudeen
    iudeen committed Aug 21, 2022
    Copy the full SHA
    402be7b View commit details
    Browse the repository at this point in the history

  6. update requirements to use wip main branch from Websockets

    @iudeen
    iudeen committed Aug 21, 2022
    Copy the full SHA
    85c342b View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Merge remote-tracking branch 'upstream/master' into feature/websocket… 

    …-headers

# Conflicts:
#	setup.py
    @iudeen
    iudeen committed Aug 24, 2022
    Copy the full SHA
    60f62c0 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into feature/websocket… 

    …-headers
    @iudeen
    iudeen committed Aug 24, 2022
    Copy the full SHA
    f290fe7 View commit details
    Browse the repository at this point in the history

  3. update requirements to use wip main branch from Websockets

    @iudeen
    iudeen committed Aug 24, 2022
    Copy the full SHA
    dc8a505 View commit details
    Browse the repository at this point in the history

  4. wip: add allow-direct-references to support installation from Git

    @iudeen
    iudeen committed Aug 24, 2022
    Copy the full SHA
    019e7d2 View commit details
    Browse the repository at this point in the history

  5. update requirements to use wip main branch from Websockets

    @iudeen
    iudeen committed Aug 24, 2022
    Copy the full SHA
    59cf6f4 View commit details
    Browse the repository at this point in the history

  6. update requirements to use wip main branch from Websockets

    @iudeen
    iudeen committed Aug 24, 2022
    Copy the full SHA
    866f3e9 View commit details
    Browse the repository at this point in the history

  7. update requirements to use wip main branch from Websockets

    @iudeen
    iudeen committed Aug 24, 2022
    Copy the full SHA
    f6a0872 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2022

  1. Merge branch 'encode:master' into feature/websocket-headers

    @iudeen
    iudeen committed Aug 28, 2022
    Copy the full SHA
    e31cd53 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Bump wsproto from 1.1.0 to 1.2.0

    @iudeen
    iudeen committed Sep 4, 2022
    Copy the full SHA
    9aa02c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. docs: amend settings.md 

    Remove the line about limitation of `no-server-header` from docs.
    @iudeen
    iudeen committed Sep 10, 2022
    Copy the full SHA
    93af5ac View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into feature/websocket… 

    …-headers

# Conflicts:
#	requirements.txt
    @iudeen
    iudeen committed Sep 10, 2022
    Copy the full SHA
    a86da4b View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Merge remote-tracking branch 'upstream/master' into feature/websocket… 

    …-headers

# Conflicts:
#	uvicorn/protocols/websockets/websockets_impl.py
    @iudeen
    iudeen committed Sep 11, 2022
    Copy the full SHA
    7daff74 View commit details
    Browse the repository at this point in the history

  2. style: ran isort

    @iudeen
    iudeen committed Sep 11, 2022
    Copy the full SHA
    97ca634 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. fix: removed _added_names logic to support arbitrary extra headers … 

    …with same name.
    @iudeen
    iudeen committed Sep 14, 2022
    Copy the full SHA
    666a8b7 View commit details
    Browse the repository at this point in the history

  2. fix: removed _added_names logic to support arbitrary extra headers … 

    …with same name.
    @iudeen
    iudeen committed Sep 14, 2022
    Copy the full SHA
    437c066 View commit details
    Browse the repository at this point in the history

  3. fix: removed _added_names logic to support arbitrary extra headers … 

    …with same name.
    @iudeen
    iudeen committed Sep 14, 2022
    Copy the full SHA
    27bd66f View commit details
    Browse the repository at this point in the history

  4. fix: removed _added_names logic to support arbitrary extra headers … 

    …with same name.
    @iudeen
    iudeen committed Sep 14, 2022
    Copy the full SHA
    50d2e9f View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Merge branch 'encode:master' into feature/websocket-headers

    @iudeen
    iudeen committed Sep 27, 2022
    Copy the full SHA
    37dcbd5 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Merge remote-tracking branch 'upstream/master' into feature/websocket… 

    …-headers
    @iudeen
    iudeen committed Oct 26, 2022
    Copy the full SHA
    adddfc3 View commit details
    Browse the repository at this point in the history

  2. chore: remove git link to websockets library

    @iudeen
    iudeen committed Oct 26, 2022
    Copy the full SHA
    52d871b View commit details
    Browse the repository at this point in the history

  3. chore: bump websockets requirement to >=10.4

    @iudeen
    iudeen committed Oct 26, 2022
    Copy the full SHA
    0be0e7c View commit details
    Browse the repository at this point in the history

  4. refactor: USER_AGENT is deprecated. Make changes to accommodate

    @iudeen
    iudeen committed Oct 26, 2022
    Copy the full SHA
    5673fa3 View commit details
    Browse the repository at this point in the history

  5. style: run black

    @iudeen
    iudeen committed Oct 26, 2022
    Copy the full SHA
    b51c8c2 View commit details
    Browse the repository at this point in the history

  6. tests: added test (improve coverage)

    @iudeen
    iudeen committed Oct 26, 2022
    Copy the full SHA
    c05759a View commit details
    Browse the repository at this point in the history

  7. tests: added test (improve coverage)

    @iudeen
    iudeen committed Oct 26, 2022
    Copy the full SHA
    b19f58a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge branch 'encode:master' into feature/websocket-headers

    @iudeen
    iudeen committed Oct 27, 2022
    Copy the full SHA
    f03c77a View commit details
    Browse the repository at this point in the history

  2. tests: added test (improve coverage) for WSProto

    @iudeen
    iudeen committed Oct 27, 2022
    Copy the full SHA
    09bcd73 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Refactor feature/websocket-headers

    @Kludex
    Kludex committed Oct 28, 2022
    Copy the full SHA
    321c8e6 View commit details
    Browse the repository at this point in the history

  2. remove unused imports

    @iudeen
    iudeen committed Oct 28, 2022
    Copy the full SHA
    da1f87f View commit details
    Browse the repository at this point in the history

  3. add clarity in docs

    @iudeen
    iudeen committed Oct 28, 2022
    Copy the full SHA
    8b545ad View commit details
    Browse the repository at this point in the history

  4. remove repeated test 

    Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
    @iudeen @Kludex
    iudeen and Kludex committed Oct 28, 2022
    Copy the full SHA
    afae8ed View commit details
    Browse the repository at this point in the history

  5. remove white space

    @iudeen
    iudeen committed Oct 28, 2022
    Copy the full SHA
    1768b31 View commit details
    Browse the repository at this point in the history