Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uvicorn gunicorn worker class restarts when USR1 is issued #1565

Merged
merged 2 commits into from Aug 26, 2022
Merged

Fix uvicorn gunicorn worker class restarts when USR1 is issued #1565

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f8a802
Fix uvicorn gunicorn worker class restarts when USR1 is issued
wonjoonSeol-WS Jul 11, 2022
03a57af
Remove comment
wonjoonSeol-WS Jul 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions uvicorn/workers.py
View file
Open in desktop
Expand Up @@ -72,6 +72,11 @@ def init_signals(self) -> None:
for s in self.SIGNALS:
signal.signal(s, signal.SIG_DFL)

# Remove me if SIGUSR1 is handled in server.py
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get this comment here... This doesn't affect uvicorn standalone. 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring to the comment from tiangolo.

This is because the UvicornWorker, which inherits from the base Gunicorn worker, declares a method init_signals() (overriding the parent method) but doesn't do anything. I suspect it's because the signal handlers are declared in the Server.install_signal_handlers() with compatibility with asyncio.

But you are right, I was thinking that install_signal_handlers() in server.py could call init_signal in future. But this is unlikely as init_signal (esp signal.signal) isn't compatible with asyncio. I will remove this comment. 03a57af

signal.signal(signal.SIGUSR1, self.handle_usr1)
# Don't let SIGUSR1 disturb active requests by interrupting system calls
signal.siginterrupt(signal.SIGUSR1, False)

async def _serve(self) -> None:
self.config.app = self.wsgi
server = Server(config=self.config)
Expand Down