Fix skipping tests requiring httptools #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kludex
requested changes
Jul 1, 2022
The test suite currently skips some tests when httptools are missing. However, there are more tests requiring it and they currently fail if that is the case. Cover them with necessary skips as well.
|
This is much nicer. Thanks, done that! |
Kludex
reviewed
Jul 1, 2022
euri10
requested changes
Jul 1, 2022
euri10
approved these changes
Jul 8, 2022
|
ok let's roll with this, thanks @mgorny and thanks for clarifications in the other PR, and thanks for packaging uvicorn :) |
|
Thanks a lot! |
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
The test suite currently skips some tests when httptools are missing. However, there are more tests requiring it and they currently fail if that is the case. Cover them with necessary skips as well.
Kludex
pushed a commit
that referenced
this pull request
Oct 29, 2022
The test suite currently skips some tests when httptools are missing. However, there are more tests requiring it and they currently fail if that is the case. Cover them with necessary skips as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test suite currently skips some tests when httptools are missing.
However, there are more tests requiring it and they currently fail
if that is the case. Cover them with necessary skips as well.