make test_http.get_connected_protocol a plain function and other post #1155 cleanups #1520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
changed the title
graingert
force-pushed
the
refactor-redundant-context-manager
branch
from
5d5e921
to
d48a3b5
Compare
this was only needed for the asyncio._set_running_loop hack
graingert
changed the title
Kludex
approved these changes
Jun 17, 2022
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
…ncode#1155 cleanups (encode#1520) * make test_http.get_connected_protocol a plain function * remove MockLoop.is_running method this was only needed for the asyncio._set_running_loop hack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up cleanup to #1155
pytest-asynciomarker byanyio#1155pytest-asynciomarker byanyio#1155