Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert log exception traceback in case of invalid HTTP request #1518

Merged
merged 2 commits into from Jun 14, 2022
Merged

Revert log exception traceback in case of invalid HTTP request #1518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0378b56
Revert "Log exception traceback in case of invalid HTTP request when …
euri10 Jun 13, 2022
699d97e
Revert "Log exception traceback in case of invalid HTTP request when …
euri10 Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions uvicorn/protocols/http/h11_impl.py
View file
Open in desktop
Expand Up @@ -162,9 +162,9 @@ def handle_events(self) -> None:
while True:
try:
event = self.conn.next_event()
except h11.RemoteProtocolError as exc:
except h11.RemoteProtocolError:
msg = "Invalid HTTP request received."
self.logger.warning(msg, exc_info=exc)
self.logger.warning(msg)
self.send_400_response(msg)
return
event_type = type(event)
Expand Down
4 changes: 2 additions & 2 deletions uvicorn/protocols/http/httptools_impl.py
View file
Open in desktop
Expand Up @@ -149,9 +149,9 @@ def data_received(self, data: bytes) -> None:

try:
self.parser.feed_data(data)
except httptools.HttpParserError as exc:
except httptools.HttpParserError:
msg = "Invalid HTTP request received."
self.logger.warning(msg, exc_info=exc)
self.logger.warning(msg)
self.send_400_response(msg)
return
except httptools.HttpParserUpgrade:
Expand Down