Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conditional on RemoteProtocolError.event_hint #1486

Merged
merged 3 commits into from Oct 31, 2022
Merged

Remove conditional on RemoteProtocolError.event_hint #1486

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05dadf7
Add code on events.CloseConnection for wsproto
Kludex May 10, 2022
cd9018b
Update uvicorn/protocols/websockets/wsproto_impl.py
Kludex Oct 29, 2022
a5dcf5d
RemoteProtocolError always have an event_hint
Kludex Oct 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 2 additions & 5 deletions uvicorn/protocols/websockets/wsproto_impl.py
View file
Open in desktop
Expand Up @@ -87,11 +87,8 @@ def data_received(self, data):
try:
self.conn.receive_data(data)
except RemoteProtocolError as err:
if err.event_hint is not None:
self.transport.write(self.conn.send(err.event_hint))
self.transport.close()
else:
self.handle_no_connect(events.CloseConnection())
self.transport.write(self.conn.send(err.event_hint))
self.transport.close()
else:
self.handle_events()

Expand Down