Annotate run function
#1421
Closed
Annotate run function
#1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Kludex |
|
@euri10 autocomplete and docstring basically Screencast.from.27-03-2022.20_12_36.mp4 |
euri10
approved these changes
Mar 27, 2022
| ) -> None: | ||
| """Run uvicorn via Python code. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
is the docstring necessary here or the type hints are enough to get the completion ?
There was a problem hiding this comment.
Annotation is enough for that, the docstring are a plus
|
ok no comments appart the one above, this does not make the autocomplete work on pycharm though |
|
If it doesn't, then it's not a valid solution :/ |
Merged
|
ok let's close this #1423 is working as intended |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I see it, we have two options here:
kwargs, and add them to the config manually.This PR is to improve the UX, as many users use
uvicorn.run(me included).This PR actually ignores the following mypy error:
uvicorn/main.py:445: error: Single overload definition, multiple required [misc]Which means the ideal solution would be
2. So, any solution satisfies me, I'll let the reviewer decide the path to go here.