New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pytest-asyncio
from 0.15.1 to 0.18.2
#1411
Conversation
706421e
to
f03f935
Compare
I'm game looking at this |
ok I spent 2h and I'm nowhere close to understand what the f** happens on windows, those warnings about unclosed resources are insanely hard to debug |
the thing I really dont get is why it fails with anyio ?? |
I think the root issue may be that on windows the closing of the ssl context is too slow but I'm not yet entirely sure |
I recall there was a bug regarding unclosed sockets in asyncio that was fixed in later versions of CPython. I do wonder why you're only hitting it now though. |
and only on windows, and it differs between 3.8 and 3.9 |
Hmmm... The 3.8 versions are different between those two OS: windows is using 3.8.10, ubuntu is using 3.8.12. |
I've just ignored those in the AnyIO test suite: https://github.com/agronholm/anyio/blob/master/pyproject.toml#L41 |
There's no 3.8.12 for Windows yet... |
probably the smart move, I'd like though to do that only on windows since we have zero issues on macos and linux |
Let's drop |
Replaces #1408
This PR adds theasyncio_mode=auto
option as well. Which means that@pytest.mark.asyncio
markers can be removed.Previous approach raised errors, which I don't have the time to solve. In any case, this PR just bumpspytest-asyncio
, and adds the configuration that is needed to match the behavior we had on 0.15.1.Both approaches fail with the same error. 😞