Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coverage precision to 96.77% #1351

Merged
merged 3 commits into from Feb 1, 2022
Merged

Fix coverage precision to 96.77% #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dea77ef
Fix coverage precision to 96.83%
Kludex Feb 1, 2022
18e9ba8
Add conditional coverage rule
Kludex Feb 1, 2022
d21d1df
Modify fail-under to check if 3.7 passes
Kludex Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/coverage
View file
Open in desktop
Expand Up @@ -8,4 +8,4 @@ export SOURCE_FILES="uvicorn tests"

set -x

${PREFIX}coverage report --show-missing --skip-covered --fail-under=97
${PREFIX}coverage report --show-missing --skip-covered --fail-under=96.77
4 changes: 4 additions & 0 deletions setup.cfg
View file
Open in desktop
Expand Up @@ -71,7 +71,11 @@ include = uvicorn/*, tests/*
plugins =
coverage_conditional_plugin

[coverage:report]
precision = 2

[coverage:coverage_conditional_plugin]
rules =
"sys_platform == 'win32'": py-win32
"sys_version_info >= (3, 8)": py-gte-38
"sys_version_info < (3, 8)": py-lt-38
2 changes: 1 addition & 1 deletion tests/test_config.py
View file
Open in desktop
Expand Up @@ -10,7 +10,7 @@

if sys.version_info < (3, 8): # pragma: py-gte-38
from typing_extensions import Literal
else:
else: # pragma: py-lt-38
from typing import Literal

import pytest
Expand Down
2 changes: 1 addition & 1 deletion uvicorn/config.py
View file
Open in desktop
Expand Up @@ -14,7 +14,7 @@

if sys.version_info < (3, 8): # pragma: py-gte-38
from typing_extensions import Literal
else:
else: # pragma: py-lt-38
from typing import Literal

import click
Expand Down