Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure HTTP connections are closed in case of data-less TCP pings #1244

Closed
wants to merge 2 commits into from
Closed

Ensure HTTP connections are closed in case of data-less TCP pings #1244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f7aeb8
Ensure HTTP connections are closed in case of data-less TCP pings
florimondmanca Nov 8, 2021
e9c8b38
Move EOF handling to implementations
florimondmanca Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions uvicorn/_handlers/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ def retrieve_exception(task: asyncio.Task) -> None:
data = reader._buffer # type: ignore
if data:
protocol.data_received(data)
else:
# Client already disconnected.
# E.g. they sent a TCP ping health check.
# Fine, let's disconnect too.
transport.close()

# Let the transport run in the background. When closed, this future will complete
# and we'll exit here.
Expand Down