Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e testing for gunicorn worker #1079

Closed
wants to merge 20 commits into from
Closed

e2e testing for gunicorn worker #1079

wants to merge 20 commits into from

Conversation

euri10
Copy link
Member

@euri10 euri10 commented Jun 13, 2021

No description provided.

@euri10 euri10 changed the title e2e testing for gunicorn e2e testing for gunicorn worker Jun 13, 2021
@euri10
Copy link
Member Author

euri10 commented Jun 13, 2021

interesting windows only error on an unrelated not-closed socket ;)

@euri10
Copy link
Member Author

euri10 commented Jun 21, 2021

interesting windows only error on an unrelated not-closed socket ;)

solved in #1080

@euri10
Copy link
Member Author

euri10 commented Jun 21, 2021

well the exit 3 solved in #1077 is well demonstrated (and solved once that patch is applied)

@euri10
Copy link
Member Author

euri10 commented Jun 21, 2021

only big issue with that e2e approach is that it slows down the testing a lot.

@Kludex
Copy link
Sponsor Member

Kludex commented Jun 21, 2021

Can we can run them in parallel? How slow it becomes?

@euri10
Copy link
Member Author

euri10 commented Jun 21, 2021

========================================================================================================== slowest durations ==========================================================================================================
77.30s setup    tests/e2e/test_gunicorn.py::test_gunicorn_default[default.py-0]
28.79s setup    tests/e2e/test_gunicorn.py::test_gunicorn_default[startup_failed.py-137]
2.60s call     tests/e2e/test_gunicorn.py::test_gunicorn_default[default.py-0]
2.10s call     tests/e2e/test_gunicorn.py::test_gunicorn_default[startup_failed.py-137]

settings up the docker images is what takes the most time

@Kludex
Copy link
Sponsor Member

Kludex commented Jun 21, 2021

We should try to cache those images then, I guess. 🤔

EDIT: Did you mean the image build or the container startup? 🤔

@euri10
Copy link
Member Author

euri10 commented Jun 21, 2021

Can we can run them in parallel? How slow it becomes?

I tried pytest-xdist which blows the test suite, I think mostly because ports used for each run_in_server are the same so maybe something worh looking at, not sure

@Kludex
Copy link
Sponsor Member

Kludex commented Jun 21, 2021

I tried pytest-xdist which blows the test suite, I think mostly because ports used for each run_in_server are the same so maybe something worh looking at, not sure

I didn't mean on the pytest level, I mean on the CI, creating two jobs in parallel.

@euri10
Copy link
Member Author

euri10 commented Jun 21, 2021

I tried pytest-xdist which blows the test suite, I think mostly because ports used for each run_in_server are the same so maybe something worh looking at, not sure

I didn't mean on the pytest level, I mean on the CI, creating two jobs in parallel.

ok I seperated them into 2 jobs using markers in pytest, would like to see once this is merged

@euri10 euri10 closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants