Added --reload-exclude-dir param #1013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strongly support this feature addition! 🙏 🥺 |
|
I also want this feature 🙏 |
|
I'm happy to rebase this and fix the conflicts if I can get some confirmation from the devs that it will be merged. |
|
Hey @dusty-phillips ! This PR has less priority than the #820, but we are not definitive yet. I really appreciate your intentions, but I'd recommend to not lose time rebasing right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New CLI feature
New
--reload-exclude-dirparameter for uvicorn-CLI allows to exclude folder from being watched by reloader. As a--reload-dirparam, it can be specified multiple times.Purpose
The idea was already described in #984. I would also mention, that WatchGod (which is used by default) reloads project even if changes were made not only to source code (Unlike Statreload). So when you have a folder with static files and user uploads image, the project gets reloaded. And adding lots of folders with param
--reload-dir, instead of just excluding one folder, can be really annoying.Working mechanism
I thought, that idea of pattern matching is not the best. Also it would be better for both of reloaders to have same excluding mechanism. So, I just compare absolute paths of files. You can not specify both included and excluded folders. Also added a few tests for this param.