Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump httptools to >=0.4.0 #1400

Merged
merged 1 commit into from Mar 11, 2022
Merged

Bump httptools to >=0.4.0 #1400

merged 1 commit into from Mar 11, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Mar 11, 2022

As there are 2 CVE that affects httptools, they've bumped the package to 0.4.0.

Do we remove the previous versions to force users to bump httptools or do we just increase the range (i.e. <0.5.0)?

Reference: MagicStack/httptools#76

@Kludex
Copy link
Sponsor Member Author

Kludex commented Mar 11, 2022

I'll create a release after this (or the alternative) is merged.

@Kludex Kludex requested a review from a team March 11, 2022 08:28
@euri10
Copy link
Member

euri10 commented Mar 11, 2022

Do we remove the previous versions to force users to bump httptools or do we just increase the range (i.e. <0.5.0)?

force bump imho, unless the fix is backported which I dont think it is looking briefly at it

@Kludex
Copy link
Sponsor Member Author

Kludex commented Mar 11, 2022

It's not backported. 👍

Thanks for the approval, and good morning Benoit! 👋

@Kludex Kludex merged commit 342ae82 into master Mar 11, 2022
@Kludex Kludex deleted the Kludex-patch-1 branch March 11, 2022 08:35
Kludex added a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants