Exit with status 3 when worker starts failed #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 12, 2021 21:58
|
@fanchunke1991 you can use the |
|
@euri10 my bad, I have already used |
euri10
approved these changes
Jun 21, 2021
Kludex
requested changes
Jun 22, 2021
There was a problem hiding this comment.
Hey @fanchunke1991 ! 👋
Thanks for the PR! 🎉
I'm quite worried about magic numbers, and the round trip to found information about them. If we could reference the same variable that gunicorn uses, it will be great. Do you mind taking a look at the suggestion?
Kludex
reviewed
Jun 22, 2021
Kludex
reviewed
Jun 22, 2021
euri10
approved these changes
Jun 22, 2021
Kludex
approved these changes
Jun 22, 2021
|
@fanchunke1991 Thanks for PR! 🎉 |
Kludex
pushed a commit
that referenced
this pull request
Nov 17, 2021
* fix: exit with status 3 when worker starts failed to aviod infinite start/stop cycles * docs: fixes spelling error * style: lint the code * fix: replace magic exit code Co-authored-by: fanchunke <fanchunke@laiye.com>
2 tasks
Kludex
pushed a commit
to sephioh/uvicorn
that referenced
this pull request
Oct 29, 2022
* fix: exit with status 3 when worker starts failed to aviod infinite start/stop cycles * docs: fixes spelling error * style: lint the code * fix: replace magic exit code Co-authored-by: fanchunke <fanchunke@laiye.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1066 .
When starting Gunicorn with Uvicorn worker, if exceptions raised at startup events,
UvicornWorkerexits with zero exit code, therefore Gunicorn will keep booting worker.This PR sets exit code 3 when worker starts failed, Gunicorn will then handle
SIGCHLDcorrectly and could shut it down to avoid infinite start/stop cycles.