Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update httptools from 0.1.* to 0.2.* #1024

Merged
merged 1 commit into from
May 28, 2021
Merged

update httptools from 0.1.* to 0.2.* #1024

merged 1 commit into from
May 28, 2021

Conversation

hidaris
Copy link
Contributor

@hidaris hidaris commented Apr 26, 2021

Httptools 0.2 replaces the underlying HTTP parser with llhttp as http-parser is
no longer actively maintained. See MagicStack/httptools#56

This was referenced May 17, 2021
Merged
Closed
@RobertoPrevato
Copy link
Contributor

Note: as far as I know, httptools 0.2.0 is also required to add compatibility with Python 3.10. This is what I experienced with blacksheep.

@hidaris
Copy link
Contributor Author

hidaris commented May 18, 2021 •
edited

@RobertoPrevato Hi, both uvicorn and httptools currently do not support python 3.10, https://github.com/encode/uvicorn/blob/master/setup.py#L89
https://github.com/MagicStack/httptools/blob/master/.github/workflows/tests.yml#L18，
Maybe we still need to wait a while, or test if 3.10 needs some tweaking work.

Kludex
Kludex approved these changes May 24, 2021
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a long way for that upgrade on httptools, and they were concerned about us. ❤️ 👍

LGTM.

@Kludex Kludex mentioned this pull request May 24, 2021
Closed
@euri10
Copy link
Member

euri10 commented May 27, 2021

github has a problem, I get a 500 when clicking Approve and run on the workflow, any ideas appart from waiting ?

@euri10 euri10 requested a review from Kludex May 27, 2021 13:19
@hidaris
update httptools from 0.1.* to 0.2.*
ae33257 
Httptools 0.2 replaces the underlying HTTP parser with llhttp as http-parser is
no longer actively maintained.
@hidaris hidaris force-pushed the update-httptools-from-0.1.-to-0.2 branch from 2e73fc2 to ae33257 Compare May 27, 2021 13:33
@hidaris
Copy link
Contributor Author

hidaris commented May 27, 2021

@euri10 I just rebase the code, now ci works properly.

@Kludex Kludex merged commit e6028a6 into encode:master May 28, 2021
@Kludex Kludex modified the milestone: 0.14.0 May 28, 2021
@hidaris hidaris deleted the update-httptools-from-0.1.-to-0.2 branch May 29, 2021 04:06
Kludex pushed a commit to sephioh/uvicorn that referenced this pull request Oct 29, 2022
@Kludex
update httptools from 0.1.* to 0.2.* (encode#1024)
40edaea 
Httptools 0.2 replaces the underlying HTTP parser with llhttp as http-parser is
no longer actively maintained.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hidaris @RobertoPrevato @euri10 @Kludex