New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Httptools trims long urls #924
Comments
Cool, I subscribed to it thanks for the heads up @victoraugustolls ! |
jfyk, @victoraugustolls PR was merged, and we have a PR using the new httptools version: #1024 |
url parsing in httptools is still handled by http-parser and llhttp has a long standing enhancement request to provide a way to do it, so using the new httptools version in fact does not change anything to this issue |
closing this a wontfix since it's an issue upstream > upstream (httptools using http-parse for url parsing) |
Prompted as part of the discussion in #344 , it seems httptools doenst handle well long url, see #925 for a failing test
I can say that for my case the issue is not URLs longer than 65,535 characters, but rather that
on_url
is being called multiple times for whatever reason: https://github.com/nodejs/http-parser#parsing-urls.Originally posted by @malthejorgensen in #344 (comment)
The text was updated successfully, but these errors were encountered: