Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging graphql tests #989

Merged
merged 2 commits into from Jun 29, 2020
Merged

Fix hanging graphql tests #989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c09a532
Use pytest-asyncio event loop when creating AsyncioExecutor in tests
vladmunteanu Jun 28, 2020
d3abd99
Reformatting line width
vladmunteanu Jun 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions tests/test_graphql.py
View file
Open in desktop
@@ -1,4 +1,5 @@
import graphene
import pytest
from graphql.execution.executors.asyncio import AsyncioExecutor

from starlette.applications import Starlette
Expand Down Expand Up @@ -149,10 +150,17 @@ def test_graphql_async():


async_schema = graphene.Schema(query=ASyncQuery)
old_style_async_app = GraphQLApp(schema=async_schema, executor=AsyncioExecutor())


def test_graphql_async_old_style_executor():
@pytest.fixture
def old_style_async_app(event_loop) -> GraphQLApp:
old_style_async_app = GraphQLApp(
schema=async_schema, executor=AsyncioExecutor(loop=event_loop),
)
return old_style_async_app


def test_graphql_async_old_style_executor(old_style_async_app: GraphQLApp):
# See https://github.com/encode/starlette/issues/242
client = TestClient(old_style_async_app)
response = client.get("/?query={ hello }")
Expand Down