Add request argument to TemplateResponse (v1.x) #2199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-oleshkevich
changed the title
aminalaee
reviewed
Jul 3, 2023
| @@ -142,17 +142,16 @@ def get_template(self, name: str) -> "jinja2.Template": | |||
|
|
|||
| def TemplateResponse( | |||
| self, | |||
| request: Request, | |||
There was a problem hiding this comment.
Any reason why this is not an optional argument so it can be released without breaking?
There was a problem hiding this comment.
This was discussed on #2191.
The diff here is actually incomplete.
|
I meant to create a PR so I could see the diff between the PR that adds deprecation and what is supposed to be refactor for v1. I mean, target the PR you are building from this one. |
|
@Kludex this PR is the target repo state after removing all deprecations. |
I need instead of "encode:master" to be "alex-oleshkevich:templates-request". 🤔 |
Not after, but for 1.0. |
|
I've applied this on #2384, and given co-author to @alex-oleshkevich . FYI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes backward compatibility done in #2191
To be merged after 1.0 release.