Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove databases package from config docs #2092

Merged
merged 17 commits into from Dec 16, 2023
Merged

Remove databases package from config docs #2092

merged 17 commits into from Dec 16, 2023

Conversation

aminalaee
Copy link
Member

Subset of #1921

@aminalaee aminalaee requested review from a team and Kludex March 24, 2023 08:02
Kludex
Kludex reviewed Mar 24, 2023
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I look for databases in the docs, I can still find others 🤔

@aminalaee
Copy link
Member Author

@Kludex You mean in the config.md file? Because I wanted to do change the other page in a separate PR.

Kludex
Kludex reviewed Mar 24, 2023
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
Kludex
Kludex requested changes Mar 27, 2023
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
Kludex
Kludex reviewed Apr 7, 2023
View reviewed changes
docs/config.md Show resolved Hide resolved
Kludex
Kludex reviewed Apr 10, 2023
View reviewed changes
docs/config.md Show resolved Hide resolved
@aminalaee aminalaee requested a review from Kludex April 18, 2023 06:27
Kludex
Kludex requested changes May 31, 2023
View reviewed changes
docs/config.md Show resolved Hide resolved
Kludex
Kludex reviewed Jun 1, 2023
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
Kludex
Kludex requested changes Jun 1, 2023
View reviewed changes
Copy link
Sponsor Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added last bit

@aminalaee @Kludex
Update docs/config.md
fc596b1 
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
Kludex
Kludex reviewed Jun 2, 2023
View reviewed changes
docs/config.md Show resolved Hide resolved
@Kludex Kludex mentioned this pull request Jun 4, 2023
Merged
Kludex
Kludex reviewed Jun 5, 2023
View reviewed changes
docs/config.md Outdated Show resolved Hide resolved
@Kludex Kludex added the hold Don't merge it label Jun 6, 2023
@Kludex Kludex removed the hold Don't merge it label Dec 16, 2023
@Kludex Kludex enabled auto-merge (squash) December 16, 2023 15:03
@Kludex Kludex merged commit 80818a4 into encode:master Dec 16, 2023
5 checks passed
@aminalaee aminalaee deleted the remove-databases-from-config-docs branch December 16, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kludex Kludex Kludex approved these changes

@BilalAlpaslan BilalAlpaslan BilalAlpaslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aminalaee @Kludex @BilalAlpaslan @musale