Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for range headers to FileResponse #1999

Closed
wants to merge 1 commit into from
Closed

Add support for range headers to FileResponse #1999

wants to merge 1 commit into from

Commits on Jan 7, 2023

  1. Add support for range headers to FileResponse 

    This PR aims to solve #950.

The implementation differs from [baize's
FileResponse](https://github.com/abersheeran/baize/blob/23791841f30ca92775e50a544a8606d1d4deac93/baize/asgi/responses.py#L184),
since that one takes in consideration the "range" request header. The
desgin decision is justified as the Response classes in Starlette are
naive in regards to the request.
    @Kludex
    Kludex committed Jan 7, 2023
    Configuration menu
    Copy the full SHA
    2612f83 View commit details
    Browse the repository at this point in the history