♻️ Add compatibility with the next version of AnyIO #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriangb
approved these changes
Nov 4, 2022
|
That was fast, thanks for the review @adriangb! 🚀 |
aminalaee
pushed a commit
that referenced
this pull request
Feb 13, 2023
bfineran
added a commit
to neuralmagic/deepsparse
that referenced
this pull request
Aug 31, 2023
this is for compatibility with the maximum currently allowed version of `starlette`. `anyio` just pushed a 4.0.0 that is incompatible with earlier versions of `starlette`. Note that this is now fixed in later versions (`deepsparse` has not yet tested against newer versions of `fastapi` and `starlette`). See: encode/starlette#1936 from internal bug report: ``` Our Deepsparse GHA is failing with starlette error: AttributeError: module 'anyio' has no attribute 'start_blocking_portal' ```
bfineran
added a commit
to neuralmagic/deepsparse
that referenced
this pull request
Aug 31, 2023
this is for compatibility with the maximum currently allowed version of `starlette`. `anyio` just pushed a 4.0.0 that is incompatible with earlier versions of `starlette`. Note that this is now fixed in later versions (`deepsparse` has not yet tested against newer versions of `fastapi` and `starlette`). See: encode/starlette#1936 from internal bug report: ``` Our Deepsparse GHA is failing with starlette error: AttributeError: module 'anyio' has no attribute 'start_blocking_portal' ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Add compatibility with the next version of AnyIO
The next version of AnyIO (agronholm/anyio@9f97cd7), not released yet, doesn't export
start_blocking_portalfrom the top level of the package, it has to be imported from directly where it is declared, infrom_thread.This keeps compatibility with the current version but adds compatibility with the next (current main branch in AnyIO's repo).