Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure MutableHeaders._list is actually a list #1917

Merged
merged 6 commits into from Oct 21, 2022
Merged

Make sure MutableHeaders._list is actually a list #1917

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5aac10d
Update datastructures.py
adriangb Oct 19, 2022
c34028a
Update datastructures.py
adriangb Oct 19, 2022
7e30ef8
Update datastructures.py
adriangb Oct 19, 2022
fb8b98c
Merge branch 'master' into adriangb-patch-1
adriangb Oct 21, 2022
7d21f5c
add test
adriangb Oct 21, 2022
53d0c6d
assign back
adriangb Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions starlette/datastructures.py
View file
Open in desktop
Expand Up @@ -585,6 +585,16 @@ def __repr__(self) -> str:


class MutableHeaders(Headers):

def __init__(
self,
headers: typing.Optional[typing.Mapping[str, str]] = None,
raw: typing.Optional[typing.List[typing.Tuple[bytes, bytes]]] = None,
scope: typing.Optional[typing.Mapping[str, typing.Any]] = None,
) -> None:
super().__init__(headers, raw, scope)
self._list = list(self._list)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think doing this (line 595) in the parent class is good enough.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a test case covering the issue is wanted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to update the branch, I’m on my phone and AFK the rest of the day

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing. Let's postpone it till morning.


def __setitem__(self, key: str, value: str) -> None:
"""
Set the header `key` to `value`, removing any duplicate entries.
Expand Down