Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable TestClient follow_redirects by default #1872

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion starlette/testclient.py
Expand Up @@ -386,7 +386,6 @@ def __init__(
base_url=base_url,
headers={"user-agent": "testclient"},
transport=transport,
follow_redirects=True,
cookies=cookies,
)

Expand Down
19 changes: 18 additions & 1 deletion tests/test_testclient.py
Expand Up @@ -9,7 +9,7 @@

from starlette.applications import Starlette
from starlette.middleware import Middleware
from starlette.responses import JSONResponse
from starlette.responses import JSONResponse, RedirectResponse
from starlette.routing import Route
from starlette.websockets import WebSocket, WebSocketDisconnect

Expand All @@ -18,9 +18,14 @@ def mock_service_endpoint(request):
return JSONResponse({"mock": "example"})


def mock_service_redirect(request):
return RedirectResponse(request.url_for("mock_service_endpoint"))


mock_service = Starlette(
routes=[
Route("/", endpoint=mock_service_endpoint),
Route("/redirect", endpoint=mock_service_redirect),
]
)

Expand Down Expand Up @@ -240,3 +245,15 @@ async def app(scope, receive, send):
client = test_client_factory(app)
response = client.get("/")
assert response.json() == {"host": "testclient", "port": 50000}


def test_client_not_follows_redirects(test_client_factory):
client = test_client_factory(mock_service)
response = client.get("/redirect")
assert response.status_code == 307
assert response.url == "http://testserver/redirect"

client = test_client_factory(mock_service)
response = client.get("/redirect", follow_redirects=True)
assert response.status_code == 200
assert response.url == "http://testserver/"