Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement __repr__ for route classes #1864

Merged
merged 17 commits into from Sep 23, 2022
Merged
Show file tree
Hide file tree
Changes from 15 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 24 additions & 0 deletions starlette/routing.py
Expand Up @@ -283,6 +283,12 @@ def __eq__(self, other: typing.Any) -> bool:
and self.methods == other.methods
)

def __repr__(self) -> str:
class_name = self.__class__.__name__
methods = sorted(self.methods or [])
path, name = self.path, self.name
return f"{class_name}(path={path!r}, name={name!r}, methods={methods!r})"


class WebSocketRoute(BaseRoute):
def __init__(
Expand Down Expand Up @@ -341,6 +347,9 @@ def __eq__(self, other: typing.Any) -> bool:
and self.endpoint == other.endpoint
)

def __repr__(self) -> str:
return f"{self.__class__.__name__}(path={self.path!r}, name={self.name!r})"


class Mount(BaseRoute):
def __init__(
Expand Down Expand Up @@ -440,6 +449,11 @@ def __eq__(self, other: typing.Any) -> bool:
and self.app == other.app
)

def __repr__(self) -> str:
class_name = self.__class__.__name__
name = self.name or ""
return f"{class_name}(path={self.path!r}, name={name!r}, app={self.app!r})"


class Host(BaseRoute):
def __init__(
Expand Down Expand Up @@ -507,6 +521,11 @@ def __eq__(self, other: typing.Any) -> bool:
and self.app == other.app
)

def __repr__(self) -> str:
class_name = self.__class__.__name__
name = self.name or ""
return f"{class_name}(host={self.host!r}, name={name!r}, app={self.app!r})"


_T = typing.TypeVar("_T")

Expand Down Expand Up @@ -847,3 +866,8 @@ def decorator(func: typing.Callable) -> typing.Callable:
return func

return decorator

def __repr__(self) -> str:
routes_count = len(self.routes)
noun = "route" if routes_count == 1 else "routes"
return f"{self.__class__.__name__}({routes_count} {noun})"
euri10 marked this conversation as resolved.
Show resolved Hide resolved
83 changes: 83 additions & 0 deletions tests/test_routing.py
Expand Up @@ -952,3 +952,86 @@ async def modified_send(msg: Message) -> None:
resp = client.get("/mount/err")
assert resp.status_code == 403, resp.content
assert "X-Mounted" not in resp.headers


def test_route_repr() -> None:
route = Route("/welcome", endpoint=homepage)
assert (
repr(route)
== "Route(path='/welcome', name='homepage', methods=['GET', 'HEAD'])"
)


def test_route_repr_without_methods() -> None:
route = Route("/welcome", endpoint=Endpoint, methods=None)
assert repr(route) == "Route(path='/welcome', name='Endpoint', methods=[])"


def test_websocket_route_repr() -> None:
route = WebSocketRoute("/ws", endpoint=websocket_endpoint)
assert repr(route) == "WebSocketRoute(path='/ws', name='websocket_endpoint')"


def test_mount_repr() -> None:
route = Mount(
"/app",
routes=[
Route("/", endpoint=homepage),
],
)
assert repr(route) == "Mount(path='/app', name='', app=Router(1 route))"


def test_mount_named_repr() -> None:
route = Mount(
"/app",
name="app",
routes=[
Route("/", endpoint=homepage),
],
)
assert repr(route) == "Mount(path='/app', name='app', app=Router(1 route))"


def test_host_repr() -> None:
route = Host(
"example.com",
app=Router(
[
Route("/", endpoint=homepage),
]
),
)
assert repr(route) == "Host(host='example.com', name='', app=Router(1 route))"


def test_host_named_repr() -> None:
route = Host(
"example.com",
name="app",
app=Router(
[
Route("/", endpoint=homepage),
]
),
)
assert repr(route) == "Host(host='example.com', name='app', app=Router(1 route))"


def test_router_repr() -> None:
route = Router(
routes=[
Route("/", endpoint=homepage),
]
)
assert repr(route) == "Router(1 route)"


def test_router_repr_plural() -> None:
route = Router(
routes=[
Route("/", endpoint=homepage),
Route("/app", endpoint=homepage),
]
)
assert repr(route) == "Router(2 routes)"