New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement __repr__ for route classes #1864
Merged
Merged
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0ac936e
implement __repr__ for Route
alex-oleshkevich 049edb9
implemenr __repr__ for WebSocketRoute, Host, and Mount.
alex-oleshkevich 8768bb9
fix linting issues
alex-oleshkevich c985166
change repr format
alex-oleshkevich 94df496
force repr() for inner apps
alex-oleshkevich af81645
Update starlette/routing.py
alex-oleshkevich ff8d3a9
Update starlette/routing.py
alex-oleshkevich c8ce4eb
Update starlette/routing.py
alex-oleshkevich d7a721f
Update starlette/routing.py
alex-oleshkevich d66d460
Update tests/test_routing.py
alex-oleshkevich 442a951
Update tests/test_routing.py
alex-oleshkevich c29042a
Update tests/test_routing.py
alex-oleshkevich 77d764d
Update tests/test_routing.py
alex-oleshkevich 162abb1
Update tests/test_routing.py
alex-oleshkevich c16be82
fix linting issues and tests
alex-oleshkevich 8087806
remove repr from Router
alex-oleshkevich c81002e
Merge branch 'master' into route-repr
Kludex File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the
!r
is used on all parameters in the other__repr__
that we have in code 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I got why... It's because with them, there's no need to wrap on parenthesis!