Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to make sure CHANGELOG is always in sync with __version__ #1714

Merged
merged 11 commits into from Jul 8, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Jun 29, 2022

Inspired by yesterday's #1713.

As proposed by @tomchristie on the last comment there, this script only makes sure the first version string found on release-notes.md matches with the first version string found on __init__.py.

If this is accepted, I'll create PRs on the other encode projects.

@Kludex Kludex requested a review from tomchristie June 29, 2022 05:05
@Kludex Kludex added this to the Version 0.21.0 milestone Jun 30, 2022
@adriangb
Copy link
Member

adriangb commented Jul 1, 2022

This seems reasonable to me. It codifies a currently manual step.

scripts/lint Outdated Show resolved Hide resolved
scripts/lint Outdated Show resolved Hide resolved
@Kludex
Copy link
Sponsor Member Author

Kludex commented Jul 7, 2022

@Kludex
Copy link
Sponsor Member Author

Kludex commented Jul 8, 2022

Merging this as the analogous was merged on uvicorn.

@Kludex Kludex merged commit e7717af into master Jul 8, 2022
@Kludex Kludex deleted the sync-version branch July 8, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants