Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid TypeError on websocket.disconnect when code is None #1574

Merged
merged 2 commits into from Apr 6, 2022
Merged

Avoid TypeError on websocket.disconnect when code is None #1574

merged 2 commits into from Apr 6, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Apr 5, 2022 •
edited

Closes #1560

@Kludex Kludex requested a review from a team April 5, 2022 19:01
@Kludex Kludex changed the title Default to 1000 in case of code being None on websocket.disconnect Avoid TypeError on websocket.disconnect when code is None Apr 5, 2022
@Kludex Kludex merged commit 487f05d into master Apr 6, 2022
@Kludex Kludex deleted the fix/close-code-websocket-endpoint branch April 6, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abersheeran abersheeran abersheeran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Denying WebSocket connection in WebSocketEndpoint.on_connect leads to Exception
2 participants
@Kludex @abersheeran