Ignore mypy issue on jinja2.contextfunction function
#1554
Conversation
Kludex
changed the title
jinja2 to be able to build with mkdocs
Kludex
changed the title
jinja2 to be able to build with mkdocsjinja2 to be able to build our docs
Kludex
changed the title
jinja2 to be able to build our docsjinja2.contextfunction function
| pass_context = jinja2.contextfunction | ||
| pass_context = jinja2.contextfunction # type: ignore[attr-defined] |
There was a problem hiding this comment.
Could you clarify why this is necessary? Is Jinja2 untyped / the types are wrong? I'm going to run this locally also, going to take me a sec tho
There was a problem hiding this comment.
The attribute is not defined on the latest jinja2 (which is the one installed for Python 3.7+).
The conditional there is because Python 3.6 will have a previous jinja2 version installed.
There was a problem hiding this comment.
Oh I see. It's just missing in newer versions of Jinja. And so MyPy complains that it's missing. Seems like a reasonable ignore.
There was a problem hiding this comment.
Can you use sys.version_info instead?
There was a problem hiding this comment.
I guess we could... I've added a note on the PR that removes Python 3.6 (#1357) to remove this logic anyway.
There was a problem hiding this comment.
I thought about that but it seems like it could lead to issues because the coupling between the Python version and Jinja2 version is coming from our requirements file, so it's pretty much an implementation detail. If there were a sys.version_info but for jinja that is what we would want to do
|
Thanks @adriangb :) |
jinja2released a new version, and as a consequence our pipeline broke.EDIT: we need to pin
jinja2on our pipeline becausemkdocsdoesn't work with the latestjinja2.