Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate WSGIMiddleware in favor of a2wsgi #1504

Merged
merged 4 commits into from Feb 11, 2022
Merged

Deprecate WSGIMiddleware in favor of a2wsgi #1504

merged 4 commits into from Feb 11, 2022

Conversation

Kludex
Copy link
Sponsor Member

@Kludex Kludex commented Feb 10, 2022

Closes #1503

@Kludex Kludex added the clean up Refinement to existing functionality label Feb 10, 2022
@tomchristie
Copy link
Member

Okay.

Which of these two options would we prefer to go with?...

  • Straight to a deprecation here.
  • Slightly more gentle route. Add a2wsgi to the docs, and to a2wsgi in the wsgi.py module docstring.

@tomchristie
Copy link
Member

I'm being over cautious in the question. It's not documented, so good plan yup! 😊

@tomchristie tomchristie merged commit 38185f3 into encode:master Feb 11, 2022
@Kludex Kludex mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomchristie tomchristie tomchristie approved these changes

Assignees
No one assigned
Labels
clean up Refinement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate WSGIMiddleware in favor of a2wsgi
3 participants
@Kludex @tomchristie @adriangb